Conversation
…ory growth, since it is used by memory.grow() for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We emitted the
__wasm_memory_sizefunction only when memory growth was enabled, but it can be used without that too.In theory we could only emit it if either memory growth or
memory.sizeis used, but I think we can expect JS minifiers to do that later.Also fix a test suite bug - the check/auto_update script didn't run all the wasm2js tests when you run it with argument
wasm2js(it used that as the list of tests, instead of the list of files, which confused me here for a while...).